Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take back -DPREFIX compiler flag when switched to meson #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Take back -DPREFIX compiler flag when switched to meson #672

wants to merge 1 commit into from

Conversation

littlewu2508
Copy link

This is a continuation of gentoo/gentoo#31017

@vapier
Copy link
Member

vapier commented Nov 28, 2023

what does "take back" mean ? what is this fixing ?

the PREFIX define is barely checked in the source tree. seems like we should be able to delete it entirely.

@littlewu2508
Copy link
Author

what does "take back" mean ? what is this fixing ?

the PREFIX define is barely checked in the source tree. seems like we should be able to delete it entirely.

Well, currently without using PREFIX macro when compiling cause openrc to misbehave on prefix systems (including gentoo/gentoo#31017 (comment), it seems that openrc of prefix is locating init files in /etc rather than ${EPREFIX}/etc).

It would be better if we can drop this macro and fix the bug of openrc on prefix system.

@littlewu2508 littlewu2508 mentioned this pull request Jan 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littlewu2508 @vapier